Re: [PATCH net-next v9 4/6] net: add AF_PACKET multicast dumps

[Yuyang Huang]

> > + err = dev_mc_fill_addr(skb, dev, ha, NETLINK_CB(cb->skb).portid,
> > +       cb->nlh->nlmsg_seq, flags, netnsid);
> > + if (err < 0)
> > + break;
> > + nl_dump_check_consistent(cb, nlmsg_hdr(skb));
>
> Why are you checking this on every iteration?

Right, we don't need to check it on every iteration, I will fix it in v10.

> The changes still lack polish IMO.

I will go over the series again for v10. If you have something
specific in mind, a pointer would help.