Re: [PATCH v7 1/9] serial: max310x: don't clobber the TX break bit in set_termios

[Tapio Reijonen]

Hi Hugo,

On 10/5/26 18:57, Hugo Villeneuve wrote:

> You commit message indicate only part of what your patch changed,
> but not why.
>
> In this case, IIUC, your patch prevent ending a preconfigured
> TX break when calling set_termios()?

Yes, exactly: a break asserted with TIOCSBRK must stay on the wire
until TIOCCBRK, but any termios change landing in between rewrote the
whole LCR register and silently ended the break early. The second
hunk covers the leftover that fix exposes: nothing clears a break
still asserted when the port is closed - the unconditional LCR write
was the accidental recovery - so startup() now clears it, the same
way 8250 does.

I can reword the message for a v8 to lead with that user-visible
failure rather than the register mechanics.

Tapio