Re: [PATCH net-next v3 1/3] net: rss: Require indir table size or hash key size to support RSS

[Maxime Chevallier]

On 10/5/26 16:29, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 (1) · Low: 1



> [Severity: Medium]
> rss_get_data_alloc() is shared by RSS_GET, RSS_SET and RSS_CREATE. Does
> this drop flow-hash reporting for devices that have ->get_rxfh but report
> 0/0 sizes?

Yes it does, that's the intended behaviour here. RSS bits are all optional,
but does it make sense to report hashing params when the indirection table
is size 0 and key len is 0 ?

Maxime