Re: [PATCH] wifi: brcmfmac: avoid sleeping tx locks in netpoll context

[Arend van Spriel]

On 06/10/2026 06:18, Karl Mehltretter wrote:
> On Sun, Oct 04, 2026 at 05:29:10AM +0100, Arend van Spriel wrote:
> > Is there an opportunity to reuse/refactor brcmf_sdio_prec_enq() rather than
> > adding a separate brcmf_sdio_prec_enq_irqoff() helper? For example, passing
> > a can_evict parameter:
>
> Thanks for the review!
>
> Sharing the helper with a can_evict argument is cleaner.
>
> One queue user does not hold txq_lock: brcmf_fws_bus_txq_cleanup()
> dequeues through brcmu_pktq_pdeq_match().
>
> Lockdep instrumentation in fcmode=1 and 2 confirmed that cleanup enters
> without txq_lock.

This is an observation unrelated to the patch, right? You mentioned in 
the patch it only covers fcmode=0, right?

> I combined the helpers, but kept brcmu_pktq_penq() for normal calls.
Sure.

Regards,
Arend