Re: [PATCH 1/5] i2c: qcom-cci: Factor out write command queue programming
From: Andi Shyti
Date: Tue Oct 06 2026 - 05:24:42 EST
Hi Loic,
the patch looks good.
> static int cci_i2c_write(struct cci *cci, u16 master,
> u16 addr, u8 *buf, u16 len)
> {
> - u8 queue = QUEUE_0;
> - u8 load[12] = { 0 };
> - int i = 0, j, ret;
> + void __iomem *loadq = cci->base + CCI_I2C_Mm_Qn_LOAD_DATA(master, QUEUE_0);
I'm not a big fan of "heavy" assignments during declaration, but
no need to resend just for this.
Andi