Re: [PATCH 3/4] ASoC: mediatek: mt8189:return 0 from mt8189_fe_startup() on success

From: Cezary Rojewski

Date: Tue Oct 06 2026 - 06:46:27 EST


On 10/6/2026 12:16 PM, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> snd_pcm_hw_constraint_integer() may return 1, which is then returned
> from mt8189_fe_startup(). ASoC only treats 0 as success when marking
> the DAI as started, so .shutdown() can be skipped on rollback.
Nothing major here, just the missing space between 'mt8189:return' in
the title.

IMHO the title could be made more explicit as you're in fact fixing how
the snd_pcm_hw_constraint_xxx() is handled by the driver. "Return 0 from
(...)" misses the point.

Kind regards,
Czarek