Re: [PATCH v2] sched: Convert last bits of deprecated static key usage

[Valentin Schneider]

On 06/10/26 12:50, Valentin Schneider wrote:
> On 03/09/26 11:57, Hongyan Xia wrote:
>> From: Hongyan Xia <hongyan.xia@xxxxxxxxxxxxx>
>>
>> Raw static keys have no type information and do not prevent mis-matches
>> (like static_key_false() on a default TRUE key). The helper names
>> static_key_{true/false}() are also confusing, hence the deprecation.
>>
>> We have already converted other sites in previous patches. Convert the
>> last sites of deprecated static key APIs. After this fix, scheduler code
>> has zero deprecated static key APIs now.
>>
>> sk_dynamic_* uses static_key_{enable/disable}(), which aren't really
>> deprecated, but take the opportunity to move to the new static_branch_*
>> APIs to be consistent.
>>
>> No functional change.
>>
>> Signed-off-by: Hongyan Xia <hongyan.xia@xxxxxxxxxxxxx>
>
> Some comprehension/changelog explanation nit below, otherwise:
>
> Reviewed-by: Valentin Schneider <vschneid@xxxxxxxxxx>
>

A quick search tells me there's still some static_key() usage spread
through the kernel, that really should be fixed in a single series powered
by coccinelle or somesuch.