Re: [PATCH net-next v8 10/11] onsemi: s2500: Add driver support for S2500 MAC-PHY

[Andrew Lunn]

> +static void s2500_update_stats(struct s2500_info *priv)
> +{

> +	/* TX bytes is a 64-bit value that is stored in two regs */
> +	*(data++) += ((u64)*rptr) | (((u64)*(rptr + 1)) << 32);


> +	/* RX bytes is a 64-bit value that is stored in two regs */
> +	*(data++) += ((u64)*rptr) | (((u64)*(rptr + 1)) << 32);

Is it guaranteed by the hardware these two words are read atomically?

> +static int s2500_ptp_write_time(struct s2500_info *priv,
> +				const struct timespec64 *ts)
> +{
> +	u32 addr;
> +	u32 data[2];

Reverse christmas tree.

	Andrew