Re: [PATCH v2] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING

[Eugene Shalygin]

Hi Matt,

On Tue, 6 Oct 2026 at 16:15, Matt Layher via B4 Relay
<devnull+mdlayher.gmail.com@xxxxxxxxxx> wrote:
>
> An LLM coding assistant did most of the work on this patch: it found the
> missing sensor while auditing this machine's monitoring, compared the
> driver's board table with the BIOS hardware monitor, worked out which EC
> register to read, and drafted the change and this changelog. I
> reviewed both, and every test below ran on my own machines.

I believe the Assisted-by: LLM sparse tag above is sufficient.

> Testing:
> - Runtime: the same one-line change applied to the driver in v6.18.54,
>   loaded on the board in place of the stock module; CPU_Opt read
>   1454-1463 RPM and the chipset fan 0.
> - Build: hwmon-next with W=1 and sparse (C=1), no warnings;
>   checkpatch --strict reports no errors, warnings or checks.

Regarding the testing section, I would suggest removing it from the
patch description as well.
While the testing is thorough, that detail is better suited for the
cover letter.

Otherwise LGTM.

Thank you,
Eugene