Re: pinctrl: sunxi: a733: irq_banks too small for port K
From: Linus Walleij
Date: Wed Oct 07 2026 - 07:05:20 EST
On Sun, Oct 4, 2026 at 11:02 PM Andre Przywara <andre.przywara@xxxxxxx> wrote:
> Norman Herms <dockseed@xxxxxxxxx> wrote:
>
> Hi Norman,
>
> > Andre, Linus,
> >
> > Observation on "pinctrl: sunxi: add support for the Allwinner A733"
> > (Andre's series [2], now in linusw/devel for 7.4):
> > the A733 pinctrl description sets .irq_banks = 10, but PA does not
> > exist there, and prepare_function_table() in pinctrl-sunxi-dt.c counts
> > IRQ banks from PA, so PB is 1 and PK is 10. This is the same
> > numbering problem as in Pablo's thread [1].
> >
>
> So I blame AI, but that below is a lot of words for a simple problem:
> the number of IRQ banks should be 11, not 10. If we go with the dummy
> IRQ. There are no official DTs for the A733 yet, so we need to decide
> there, and I guess that depends on the outcome of the A523 problem.
> I will send a fix after -rc1, with one of the solutions - unless you
> beat me to it.
Sounds good to me, and yeah the AI just loves to talk, to the
point of making you not see the forest for all the trees. :/
Yours,
Linus Walleij