Re: [PATCH v2 1/2] soc: qcom: rpmh-rsc: Update CMD_MSGID_LEN to 4 bytes for read request
From: Maulik Shah
Date: Wed Oct 07 2026 - 07:43:57 EST
On 05-10-2026 12:40, Dmitry Baryshkov wrote:
> On Mon, Oct 05, 2026 at 12:30:21PM +0530, Mukesh Ojha wrote:
>> On Fri, Sep 11, 2026 at 02:38:13PM +0530, Maulik Shah wrote:
>>> Newer SoC like hawi with RSC version v4.5 support 4 byte message read
>>> request instead of default 8 byte on older SoCs. The write request
>>> continues to be 8 bytes.
>>>
>>> The CMD_MSGID_LEN field is [3:0] bits. Describe the length bits as a
>>> GENMASK() and use FIELD_PREP() when programming 4-byte or 8-byte message
>>> length.
>>>
>>> Tested-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx> #Hawi
>>> Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
>> I know LPC is going to start today, but I wanted to highlight this patch
>> specifically, as without it, both Hawi and Maili SoC do not boot up at all.
>>
>> Can this be picked up as an independent patch for 7.4 as conveyed in the
>> cover letter?
> You've sent two patches in the same series. Typically maintainers prefer
> to pick all or nothing. Also, Fixes should come before the actual
> changes.
Let me drop patch-2 and send only patch-1 in v3.
patch-2 may wait for some more comments as per [1] before merging in as fixes.
[1] https://lore.kernel.org/lkml/53ea0718-285e-4e81-8f95-76e9b0c0f6af@xxxxxxxxxxxxxxxx/ ;
Thanks,
Maulik