Re: [PATCH v2 1/2] staging: rtl8723bs: replace uint with u32 in hal_intf.[ch]

[Pranav Desai]

> That's very odd, shouldn't this be 'int' and return either 0 for
> success, or -ERROR value for an error?

Hi Greg,

The driver's custom _SUCCESS (1) and _FAIL (0) macros are currently hardcoded into the caller logic
across multiple files. Changing rtw_hal_init() to return standard error codes in this patch would invert the
caller logic and cause regressions.

Replacing the _SUCCESS/_FAIL architecture requires a driver-wide refactor. To avoid scope creep, I have dropped
the hal_intf.c changes from this series entirely.

I just submitted v3 focusing exclusively on explicitly typing variables in rtw_security.c. I will address the
_SUCCESS/_FAIL macro teardown in a separate patch series.


Thanks,

Pranav