Re: [PATCH] selftests: timers: skip raw_skew when adjtimex fails

From: John Stultz

Date: Wed Oct 07 2026 - 14:07:58 EST


On Wed, Oct 7, 2026 at 1:16 PM Daniel Syauqi <syauqicode@xxxxxxxxx> wrote:
>
> raw_skew reads frequency and offset data from adjtimex() without checking
> whether either query succeeded. If a sandbox blocks the syscall, the
> test can use uninitialized data and wait two minutes before producing a
> misleading result.
>
> Skip on either failure and report the syscall error. Preserve errno
> across the newline printed after the second query.
>
> Fixes: 51f91cbdf545 ("selftests/timers: Add clock skew estimation test from timetest suite")
> Assisted-by: LLM Codex
> Signed-off-by: Daniel Syauqi <syauqicode@xxxxxxxxx>

Looks reasonable to me.
Acked-by: John Stultz <jstultz@xxxxxxxxxx>