Re: [PATCH net-next v2] net: ag71xx: Use default NAPI weight
From: Andrew Lunn
Date: Wed Oct 07 2026 - 14:28:34 EST
On Wed, Oct 07, 2026 at 10:36:28AM -0700, Rosen Penev wrote:
> Drop the custom NAPI weight and let netif_napi_add() use the core
> default.
>
> The old comment claimed larger weights wasted cycles and cache, but
> recent RX and TX path changes altered those tradeoffs. Keep the driver
> on the standard default unless measurements show a device-specific value
> is needed.
>
> iperf3:
>
> Before:
>
> [ ID][Role] Interval Transfer Bitrate Retr
> [ 5][TX-C] 0.00-10.00 sec 327 MBytes 274 Mbits/sec 31 sender
> [ 5][TX-C] 0.00-10.00 sec 325 MBytes 273 Mbits/sec receiver
> [ 7][RX-C] 0.00-10.00 sec 170 MBytes 143 Mbits/sec 0 sender
> [ 7][RX-C] 0.00-10.00 sec 170 MBytes 143 Mbits/sec receiver
>
> After:
>
> [ ID][Role] Interval Transfer Bitrate Retr
> [ 5][TX-C] 0.00-10.00 sec 341 MBytes 286 Mbits/sec 30 sender
> [ 5][TX-C] 0.00-10.00 sec 338 MBytes 284 Mbits/sec receiver
> [ 7][RX-C] 0.00-10.00 sec 184 MBytes 154 Mbits/sec 0 sender
> [ 7][RX-C] 0.00-10.00 sec 184 MBytes 154 Mbits/sec receiver
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew