RE: [PATCH net-next v8 09/11] net: phy: ncn26000: Support for loopback

[Selvamani Rajagopal]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, October 6, 2026 6:05 AM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@xxxxxxxxxx>
> Subject: Re: [PATCH net-next v8 09/11] net: phy: ncn26000: Support for loopback
> 
> 
> Naming is hard, and i'm not too sure about this one.
> 
> fixed_speed could actually mean, fix the PHY to use the given speed.
> It is in fact doing the opposite, the speed is not fixed at all, it is
> left to whatever the device supports. In this case, it just supports a
> single speed, but that is unusual for PHYs.
> 
> Maybe call it genphy_loopback_no_speed()?


Sure. I couldn't come up better naming. That's why I came up with
fixed_speed as PHY has its speed fixed at 10mbps.

Will replace fixed_speed with no_speed.

> 
> This helper is also not what most devices actually want to use, since

True. As you could see, we could find only one other vendor (dp83867.c) require 
loopback setting without setting speed. Actually, you found this code.

Also interesting to note that among the two vendors who have OA TC6 PHY driver, 
one is supporting MAC level loopback (adin1140-phy.c) and while the other (microchip-t1s.c)
is yet to add loopback support . We are using MII level loopback. May be, we could get this
aligned later.

> would want to use this, not genphy_loopback. Please expand the
> documentation a bit to make it clearer why you would want to use this
> and not genphy_loopback.

Will do.

> 
> 
> Andrew