Re: [PATCH 26/74] media: qcom: camss: vfe: Call vfe_subdev_init after not before significant enumeration

From: Gjorgji Rosikopulos (Consultant)

Date: Thu Oct 08 2026 - 01:56:10 EST


Please update commit message what this fixes and why is needed?

On 10/5/2026 8:13 PM, Bryan O'Donoghue wrote:
> Signed-off-by: Bryan O'Donoghue <bod@xxxxxxxxxx>
> ---
> drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 8899f02ceba02..667cda379be44 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -1930,7 +1930,6 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
> return -EINVAL;
>
> vfe->res = &res->vfe;
> - vfe->res->hw_ops->subdev_init(dev, vfe);
>
> /* Power domain */
>
> @@ -2067,6 +2066,8 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
> }
> }
>
> + vfe->res->hw_ops->subdev_init(dev, vfe);
> +
> init_completion(&vfe->reset_complete);
> init_completion(&vfe->halt_complete);
>
>