Re: [PATCH 31/74] media: qcom: camss: vfe: Add support for updating multiple write-masters within an output group

From: Gjorgji Rosikopulos (Consultant)

Date: Thu Oct 08 2026 - 02:11:15 EST


I think that all the changes for new API should come in one patch not sure why are you spiting them,
they will create room of bisect errors.

~Gjorgji

On 10/5/2026 8:14 PM, Bryan O'Donoghue wrote:
> Signed-off-by: Bryan O'Donoghue <bod@xxxxxxxxxx>
> ---
> drivers/media/platform/qcom/camss/camss-vfe.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index c078af53b0758..20d8b3e1e4459 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -673,8 +673,11 @@ static int vfe_enable_one_output(struct vfe_line *line, struct vfe_output *outpu
> if (!output->buf[i])
> break;
> output->gen2.active_num++;
> - ops->vfe_wm_update(vfe, output->wm[0].bus_client,
> - output->buf[i]->addr[0], line);
> + if (ops->vfe_output_update)
> + ops->vfe_output_update(vfe, output, output->buf[i]);
> + else
> + ops->vfe_wm_update(vfe, output->wm[0].bus_client,
> + output->buf[i]->addr[0], line);
> ops->reg_update(vfe, line->id);
> }
>
> @@ -741,8 +744,11 @@ int vfe_queue_buffer_v2(struct camss_video *vid,
> if (output->state == VFE_OUTPUT_ON &&
> output->gen2.active_num < 2) {
> output->buf[output->gen2.active_num++] = buf;
> - ops->vfe_wm_update(vfe, output->wm[0].bus_client,
> - buf->addr[0], line);
> + if (ops->vfe_output_update)
> + ops->vfe_output_update(vfe, output, buf);
> + else
> + ops->vfe_wm_update(vfe, output->wm[0].bus_client,
> + buf->addr[0], line);
> ops->reg_update(vfe, line->id);
> } else {
> vfe_buf_add_pending(output, buf);
>