Re: [PATCH 35/74] media: qcom: camss: vfe: Add helper __vfe_pix_format_is_raw

[Gjorgji Rosikopulos (Consultant)]

Hi Bryan,

On 10/5/2026 8:14 PM, Bryan O'Donoghue wrote:
> It does exactly what it says on the tin.

I dont think it does exact what it says, my comments inline,

> 
> Signed-off-by: Bryan O'Donoghue <bod@xxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss-vfe.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 9793df66b4149..43c91ec8db494 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -340,6 +340,18 @@ static const struct camss_format_info formats_pix_8x96[] = {
>  	  PER_PLANE_DATA(0, 1, 1, 1, 1, 16) },
>  };
>  
> +static bool __vfe_pix_fmt_is_raw(const struct camss_formats *fmts, u32 code)
> +{
> +	unsigned int i;
> +
> +	for (i = 0; i < fmts->nformats; i++) {
> +		if (fmts->formats[i].code == code)
> +			return true;
> +	}

This function checks whether there is code present in the formats, it can be raw/yuv anything
why is called is_raw? Can it be is_mbus_code_supported? Or something similar?

~Gjorgji