Re: [PATCH v3 03/11] dt-bindings: pinctrl: sun4i-a10: add Allwinner B288

From: Pablo Mazzini

Date: Thu Oct 08 2026 - 02:55:34 EST


Hi Rob,

The B288 uses the same scheme as the A523, and the A733 queued for
7.4, which the shared pinctrl-sunxi-dt helper parses, so I'd rather
stay consistent with them.
Andre, what do you think?

Thanks,
Pablo

On Wed, Oct 7, 2026 at 10:16 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Mon, Oct 05, 2026 at 09:27:23PM +0100, Pablo Mazzini wrote:
> > The B288 driver takes its mux values from the DT, so allwinner,pinmux
> > becomes an allowed property here, required for this compatible only.
> >
> > Signed-off-by: Pablo Mazzini <pmazzini@xxxxxxxxx>
> > ---
> > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 22 +++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> > index 45b7a0b6c626..b1f093d218f5 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> > @@ -39,6 +39,7 @@ properties:
> > - allwinner,sun8i-a33-pinctrl
> > - allwinner,sun8i-a83t-pinctrl
> > - allwinner,sun8i-a83t-r-pinctrl
> > + - allwinner,sun8i-b288-pinctrl
> > - allwinner,sun8i-h3-pinctrl
> > - allwinner,sun8i-h3-r-pinctrl
> > - allwinner,sun8i-r40-pinctrl
> > @@ -120,6 +121,15 @@ patternProperties:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [10, 20, 30, 40]
> >
> > + allwinner,pinmux:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description:
> > + Pinmux selector value, for each pin. Only used by SoCs whose
> > + driver takes the mux values from the DT instead of an in-driver
> > + table. Almost every time this value is the same for all pins, so
> > + any array shorter than the number of pins will repeat the last
> > + value, to allow just specifying a single cell, for all cells.
>
> Perhaps new platforms should move to the common 'pinmux' property?
>
> Rob