Re: [PATCH] crypto: marvell/octeontx - clean up VF resources when DOWN fails

[Herbert Xu]

On Sun, Oct 04, 2026 at 12:26:34AM -0400, Myeonghun Pak wrote:
> A failed DOWN mailbox notification makes otx_cptvf_remove() skip all
> local cleanup. The driver core still completes unbind and releases the
> devm-allocated cptvf, leaving the raw IRQ handlers registered with that
> object as their argument. The sysfs group, crypto device-table entry,
> software queues and PCI resources also remain uncleaned.
> 
> Keep the notification error diagnostic, but run the existing local
> cleanup regardless of the PF response. This removes both IRQ handlers
> before killing the tasklet and releasing its resources, as on the
> successful notification path.
> 
> This issue was identified during our ongoing static-analysis research
> while reviewing kernel code.
> 
> Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> ---
>  .../crypto/marvell/octeontx/otx_cptvf_main.c  | 29 +++++++++----------
>  1 file changed, 14 insertions(+), 15 deletions(-)

Please check

https://sashiko.dev/#/patchset/20261004042634.1130247-1-mhun512%40gmail.com

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt