Re: [PATCH v2 1/2] dt-bindings: power: spacemit: Add power domain controller IDs

[Icenowy Zheng]

在 2026-10-08四的 08:27 +0100，Conor Dooley写道：
> On Thu, Oct 08, 2026 at 03:44:29AM +0000, Yixun Lan wrote:
> > Add initial power domain driver support for SpacemiT K1/K3 SoC, The
> > Power
> > Domain Controller is SoC internal module which is part of APMU
> > (Advanced
> > Power Management Unit), it is responsible for managing power across
> > multi
> > power domains, which includes power on/off, isolation, power-on
> > sequence.
> 
> You should prob mention that this APMU is already documented
> elsewhere.

Maybe it's also meaningful to mention that APMU already has #power-
domain-cells property, because the first reaction of me is to add such
a property (and then found it already there).

Thanks,
Icenowy

> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> pw-bot: not-applicable
> 
> Thanks,
> Conor.
> 
> > 
> > Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>
> > ---
> >  include/dt-bindings/power/spacemit,k1-power.h | 14 ++++++++++++++
> >  include/dt-bindings/power/spacemit,k3-power.h | 12 ++++++++++++
> >  2 files changed, 26 insertions(+)
> > 
> > diff --git a/include/dt-bindings/power/spacemit,k1-power.h
> > b/include/dt-bindings/power/spacemit,k1-power.h
> > new file mode 100644
> > index 000000000000..41ef540b5c44
> > --- /dev/null
> > +++ b/include/dt-bindings/power/spacemit,k1-power.h
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +
> > +#ifndef _DT_BINDINGS_SPACEMIT_K1_POWER_H_
> > +#define _DT_BINDINGS_SPACEMIT_K1_POWER_H_
> > +
> > +#define K1_PMDOMAIN_VPU		0
> > +#define K1_PMDOMAIN_GPU		1
> > +#define K1_PMDOMAIN_LCD		2
> > +#define K1_PMDOMAIN_ISP		3
> > +#define K1_PMDOMAIN_AUDIO	4
> > +#define K1_PMDOMAIN_GNSS	5
> > +#define K1_PMDOMAIN_HDMI	6
> > +
> > +#endif
> > diff --git a/include/dt-bindings/power/spacemit,k3-power.h
> > b/include/dt-bindings/power/spacemit,k3-power.h
> > new file mode 100644
> > index 000000000000..519fbf946312
> > --- /dev/null
> > +++ b/include/dt-bindings/power/spacemit,k3-power.h
> > @@ -0,0 +1,12 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +
> > +#ifndef _DT_BINDINGS_SPACEMIT_K3_POWER_H_
> > +#define _DT_BINDINGS_SPACEMIT_K3_POWER_H_
> > +
> > +#define K3_PMDOMAIN_VPU		0
> > +#define K3_PMDOMAIN_GPU		1
> > +#define K3_PMDOMAIN_AUDIO	2
> > +#define K3_PMDOMAIN_LCD0	3
> > +#define K3_PMDOMAIN_LCD1	4
> > +
> > +#endif
> > 
> > -- 
> > 2.56.0
> >