[PATCH 22/24] ASoC: renesas: rz-ssi: Ensure the component is marked as opened on success

From: phucduc . bui

Date: Thu Oct 08 2026 - 06:47:32 EST


From: bui duc phuc <phucduc.bui@xxxxxxxxx>

snd_pcm_hw_constraint_integer() may return 1, which is then returned
from rz_ssi_pcm_open_xx(). ASoC only marks the component as opened when
.open() returns 0.

This currently has no functional impact, as the component driver has no
.close() callback. Still, return 0 explicitly on success to match what
ASoC expects and ensure the component is correctly marked as opened.

Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
---
sound/soc/renesas/rz-ssi.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c
index b1587f499cb8..2e297f721bb6 100644
--- a/sound/soc/renesas/rz-ssi.c
+++ b/sound/soc/renesas/rz-ssi.c
@@ -937,17 +937,29 @@ static const struct snd_pcm_hardware rz_ssi_pcm_hardware = {
static int rz_ssi_pcm_open_pio(struct snd_soc_component *component,
struct snd_pcm_substream *substream)
{
+ int ret;
+
snd_soc_set_runtime_hwparams(substream, &rz_ssi_pcm_hardware);

- return snd_pcm_hw_constraint_integer(substream->runtime,
+ ret = snd_pcm_hw_constraint_integer(substream->runtime,
SNDRV_PCM_HW_PARAM_PERIODS);
+ if (ret < 0)
+ return ret;
+
+ return 0;
}

static int rz_ssi_pcm_open_dma(struct snd_soc_component *component,
struct snd_pcm_substream *substream)
{
- return snd_pcm_hw_constraint_integer(substream->runtime,
- SNDRV_PCM_HW_PARAM_PERIODS);
+ int ret;
+
+ ret = snd_pcm_hw_constraint_integer(substream->runtime,
+ SNDRV_PCM_HW_PARAM_PERIODS);
+ if (ret < 0)
+ return ret;
+
+ return 0;
}

static snd_pcm_uframes_t rz_ssi_pcm_pointer(struct snd_soc_component *component,
--
2.43.0