Re: [PATCH RESEND 0/3] x86/vdso: Improve vdso=/vdso32= boot parameter validation
From: Habil Eren Türker
Date: Thu Oct 08 2026 - 07:10:12 EST
On Mon Aug 31 2026 at 12:16:58PM +0200 Thorsten Blum wrote:
> Replace the deprecated simple_strtoul() [1] with kstrtouint() when
> parsing the vDSO boot parameters. This provides strict input validation,
> rejects partial input, and warns when disabling vDSO for invalid values.
> Adjust both warnings for consistency and update the documentation.
I took time to review and test your series on top of v7.3-rc5.
Both the code and the runtime behaviour look correct to me:
Code review:
- kstrtouint() preserves the original semantics of simple_strtoul()
while adding proper overflow checking.
- Error paths are consistent with the existing vdso_setup() logic.
- The documentation removal for vdso32=2 is accurate.
Runtime testing:
- x86_64 QEMU/q35 guest, TCG acceleration, qemu64 CPU model
- KASAN profile (KASAN + KFENCE + DEBUG_OBJECTS)
- memory suite at 256M/512M/1G, 3 iterations per case
- All cases pass, no KASAN/KCSAN/lockdep findings, CRIT_ERRORS=0
Reviewed-by: Habil Eren Türker <habilerenturker@xxxxxxxxxxx>
Tested-by: Habil Eren Türker <habilerenturker@xxxxxxxxxxx>
Regards,
Türker