Re: (2) [PATCH v2 2/2] ext4: track zeroed out blocks of unwritten extents for fast commit

[Jan Kara]

On Thu 08-10-26 19:26:15, Daejun Park wrote:
> On Thu, Oct 08, 2026 at 11:55:02 +0200, Jan Kara wrote:
> > Just one note: I agree with you ext4_alloc_file_blocks() is actually handled
> > correctly. But OTOH tracking a range twice isn't really an issue (only tiny
> > performance overhead compared to the extent tree operations and zeroing
> > itself). So I just wouldn't special-case ext4_alloc_file_blocks() and
> > always pass a proper handle to ext4_issue_zeroout(). That keeps the logic
> > slightly simpler: kernel zeroes out blocks => kernel tracks the range. But
> > I don't really insist, it's just a suggestion.
> 
> Thanks for the review. I wasn't sure I should do that in
> ext4_alloc_file_blocks(): f4265b8d32c4 ("ext4: add
> FALLOC_FL_WRITE_ZEROES support") issues the zeroout outside of the
> running transaction on purpose, and passing a handle there would put it
> under the conversion handle, so I left it as it is.

Ah, I see. OK, makes sense. Thanks for having a look!

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR