Re: [PATCH 25/74] media: qcom: camss: vfe: Define output based VFE controls

[Bryan O'Donoghue]

On 08/10/2026 06:55, Gjorgji Rosikopulos (Consultant) wrote:
> > +
> > +	/* Output based API - new and shiny */
> > +	void (*vfe_output_start)(struct vfe_device *vfe, struct vfe_output *output);
> > +	void (*vfe_output_stop)(struct vfe_device *vfe, struct vfe_output *output);
> > +	void (*vfe_output_buf_done)(struct vfe_device *vfe, struct vfe_output *output);
> > +	void (*vfe_output_update)(struct vfe_device *vfe, struct vfe_output *output,
> > +				  struct camss_buffer *buf);
> > +
> This also deserves good commit message, this is exact copy of the other RDI API with other arguments 🙂 Shall we migrate
> all existing drivers to this api in respect to use other deprecated API but having both of them leave in vfe file which
> creates even more confusion and readability of the code?

Ah but that's the point.

You add in a parallel API which is 1:1 but which can be extended to 
describe completion groups not WM indexes.

WM indexes have always been wrong - limited to RDI and we have all sorts 
of spaghetti code to work around that indexing mismatch.

The fix is to stop doing that so yes, implement output / bus-client / 
completion group - with wm and planes described in the output layer and 
then move everything to that new interface.

Including new submissions. The only real barrier is finding old 
hardware, making the changes and ensuring nothing breaks.

Since there's no DT dependency its "just software" - easy.

---
bod