Re: [PATCH 4/5] drivers/virt: pkvm: Handle a granule larger than PAGE_SIZE for MMIO_GUARD

[Fuad Tabba]

Hi Vincent,

On Wed, 07 Oct 2026 16:02:54 +0100, Vincent Donnefort
<vdonnefort@xxxxxxxxxx> wrote:
[...]
> Validate the memory regions are aligned with the hypervisor granule
> before enabling the MMIO_GUARD support. If aligned, then the MMIO
> regions are and overshooting is safe as MMIO_GUARD is solely here to
> indicate to the hypervisor where the MMIO regions are.

nit: "the MMIO regions are and overshooting" is missing a word, "aligned"?

> It is possible to add new memory regions with memory hotplug later.
> However the alignment requirement is way more conservative than the
> maximum granule size of 64K. Nonetheless, add a test to document the
> limitation.

nit: this is a runtime check that disables MMIO_GUARD, so "add a
check" rather than "add a test"?

Reviewed-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>

Cheers,
/fuad