[PATCH 0/6] ASoC: Fix controls that write another control's bits

[HyeongJun An]

In the es8316 thread Mark suggested checking at registration time for
controls whose register fields overlap [1]. Before adding such a check,
I wanted to see what it would find in the tree today.

A script expanded the control tables of every ASoC driver built by
allmodconfig and looked for two controls in one table whose register
fields overlap. It found 80 pairs in 33 drivers. Most are real bugs.
The rest are deliberate, where two names drive the same field, such as
the AC and DRC mode thresholds in sta32x.

This series fixes six that I could confirm against the vendor
datasheet. In each one, writing a control changes a different control,
and the bits it should own cannot be reached. Most date back to the
first version of the driver.

One more is left out on purpose. The cs42l56 ADC Mute Switch writes the
ADC invert bits. The real mute bits are also written by the
cs42l56_mute() callback on every stream start and stop, so moving the
control there would let the stream mute override it. I am not sure
whether you would rather move it or drop it.

I have none of this hardware, so these are checked against the
datasheets only. More fixes, checked against the register headers,
and the registration time check would follow.

[1] https://lore.kernel.org/all/0fefbfe1-021b-46b2-8945-15956e75e37f@xxxxxxxxxxxxx/

HyeongJun An (6):
  ASoC: cs42l56: Put the Limiter Cushion control on the limiter register
  ASoC: cs42l52: Fix the NG Type Switch bit
  ASoC: pcm3168a: Fix the DAC zero flag polarity bit
  ASoC: max98371: Fix the Speaker DHT Min Volume bits
  ASoC: wm8978: Fix the 128x oversampling switch bits
  ASoC: nau8822: Fix the 128x oversampling switch bits

 sound/soc/codecs/cs42l52.c  | 2 +-
 sound/soc/codecs/cs42l56.c  | 2 +-
 sound/soc/codecs/max98371.c | 2 +-
 sound/soc/codecs/nau8822.c  | 4 ++--
 sound/soc/codecs/pcm3168a.c | 2 +-
 sound/soc/codecs/wm8978.c   | 4 ++--
 6 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.43.0