[PATCH RFC 3/9] drm/bridge: drop the bridge pointer from drm_bridge_state
From: Dmitry Baryshkov
Date: Thu Oct 08 2026 - 09:16:29 EST
struct drm_bridge_state carries a pointer to the bridge it belongs to.
It was needed when the bridge state was introduced, as the private
object state it is based on had no link to its object back then. Since
commit 97a1f01b3f2f ("drm/atomic: Add atomic_print_state to private
objects") struct drm_private_state has such a link, making the bridge
pointer redundant. Nothing reads it anymore, it is only kept up to date
by the state helpers.
Drop the pointer. The bridge can be obtained from the state with
drm_priv_to_bridge(state->base.obj).
Assisted-by: LLM
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/drm_atomic_state_helper.c | 2 --
include/drm/drm_atomic.h | 5 -----
2 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
index 406157a3660f..f66937d7044e 100644
--- a/drivers/gpu/drm/drm_atomic_state_helper.c
+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
@@ -759,7 +759,6 @@ void __drm_atomic_helper_bridge_duplicate_state(struct drm_bridge *bridge,
{
__drm_atomic_helper_private_obj_duplicate_state(&bridge->base,
&state->base);
- state->bridge = bridge;
}
EXPORT_SYMBOL(__drm_atomic_helper_bridge_duplicate_state);
@@ -822,7 +821,6 @@ void __drm_atomic_helper_bridge_state_init(struct drm_bridge_state *state,
struct drm_bridge *bridge)
{
__drm_atomic_helper_private_obj_create_state(&bridge->base, &state->base);
- state->bridge = bridge;
}
EXPORT_SYMBOL(__drm_atomic_helper_bridge_state_init);
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index 3ae35b09c0cf..095b9db145b7 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -1381,11 +1381,6 @@ struct drm_bridge_state {
*/
struct drm_private_state base;
- /**
- * @bridge: the bridge this state refers to
- */
- struct drm_bridge *bridge;
-
/**
* @input_bus_cfg: input bus configuration
*/
--
2.47.3