Re: [PATCH net v3 1/2] eth: fbnic: Preserve channels across resume

[Björn Töpel]

netdev-bot+sashiko@xxxxxxxxxx writes:

> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 2 · Medium: 0 (2) · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] This patch makes resume fail outright when fewer MSI-X vectors
>   come back than before suspend, and the commit message describes that…
> - [High] After one failed resume, num_napi stays 0 for good, and the next
>   open divides by zero and oopses.

Handling fewer IRQs is left for a separate patch, as noted in the commit
message and cover letter. I'll fix the "still fails" wording.

Hmm, you're right about num_napi. It now holds the configured channel
count, so clearing it on error is wrong. I'll drop that assignment. The
napi[0] check handles the freed vectors.

pw-bot: cr 

> Pre-existing issues:
> - [Medium] This problem wasn't introduced by this patch, but
>   __fbnic_pm_attach() calls fbnic_up() without holding rtnl or the…
> - [Medium] This problem wasn't introduced by this patch, but
>   fbnic_service_task_stop() uses cancel_delayed_work(), which does not…

Both medium issues are already present before this series. I'll keep
this series focused on the channel and queue-count fixes. These can be
handled separately.


Björn