Re: [PATCH net] net/mlx5: Lag, only cache max_tx_speed that FW has not accepted

[Tariq Toukan]

On 08/10/2026 19:48, Jakub Kicinski wrote:
> On Mon, 05 Oct 2026 07:42:28 +0000 netdev-bot+sashiko@xxxxxxxxxx wrote:
> > - [Medium] This patch breaks the query-failure fallback added by commit
> >    ad0ae7aefa7a ("net/mlx5: E-Switch, preserve max tx speed on vport…
> > - [Medium] The commit message does not match the code change.
>
> Can y'all comment please? It's been 3 days

Hi Jakub,

We received 3 different emails from Sashiko bots for this single patch.
Or replied to a similar issue in another Sashiko mail, but now I see it 
wasn't the netdev one.

Anyway, sorry for the delay.

The fallback readers in mlx5_modify_vport_admin_state() and 
mlx5_esw_adj_vport_modify() were removed by 86b785b18f8f ("Revert 
\"net/mlx5: E-Switch, preserve max tx speed on vport state 
modification\""), which is now in net, so clearing the cache no longer 
affects them.

The second point is fair. The issue is theoretical (found by the AI 
review of an earlier series, not observed), and the commit message does 
not describe the actual change, which is to stop replaying values FW 
already accepted.

pw-bot: cr