Re: [PATCH] clk: qcom: mmcc-sdm660: Do not keep the video core clock always on

[Dmitry Baryshkov]

On Thu, Oct 08, 2026 at 06:49:18PM -0300, Fabricio Akio via B4 Relay wrote:
> From: Fabricio Akio <fabricioakio@xxxxxxxxx>
> 
> video_core_clk_src is marked CLK_IS_CRITICAL, so it is kept prepared and
> enabled from boot, and with it its parent XO, which the RPM then can
> never shut down. Nothing records why: the clock only feeds the video
> codec, whose driver enables the core clock it needs, and the same clock
> is not critical on MSM8996 or MSM8998.
> 
> Drop the flag.
> 
> Fixes: 5db3ae8b33de ("clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver")
> Signed-off-by: Fabricio Akio <fabricioakio@xxxxxxxxx>
> ---
> Tested on a Motorola Moto X4 (SDM630): with the other votes that hold
> XO removed, the SoC shut XO down in every suspend with this change and
> in none without it. With the video codec enabled for the test, it
> probed and loaded its firmware, and the clock was off while the codec
> was idle.
> ---
>  drivers/clk/qcom/mmcc-sdm660.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


-- 
With best wishes
Dmitry