Re: [PATCH net-next v8 2/2] net: wwan: mhi_wwan_ctrl: drive DTR/RTS via the IP_CTRL channel

[Peter Hunt]

Hi Loic,

On Thu, Oct 8, 2026 at 5:30 PM Loic Poulain wrote:
> This function ensures that the work is either cancelled or has
> completed, but it does not prevent it from being requeued
> concurrently. That can happen when rx_refill is rescheduled from
> mhi_wwan_dtr_queue_rx(). Using disable_delayed_work_sync() here would
> be preferable.

Agreed, thanks. The automated review of v7 also pointed out that a
retry already inside mhi_queue_buf() could race with
mhi_unprepare_from_transfer(). In v9 the DL sink buffer is only ever
requeued from the refill work (the DL callback just schedules it), and
remove() calls disable_delayed_work_sync() before
mhi_unprepare_from_transfer(), the same order mhi_wwan_ctrl_stop()
already uses for the data ports.

Thanks,
Peter