Re: [PATCH 1/6] firewire: core: use spinlock_irqsave() appropriately for transaction list lock

[Takashi Sakamoto]

On Fri, Oct 09, 2026 at 08:44:27AM +0900, Takashi Sakamoto wrote:
> The transaction.lock in the fw_card structure protects the transaction
> list from concurrent access. The list is mostly accessed from process
> context, with two exceptions: split_transaction_timeout_callback()
> acquires the lock in softIRQ context for the timer wheel, and
> __fw_send_request() acquires it in the caller's context, which can
> include hardIRQ context.
> 
> Use spinlock_irq() in process context and spinlock_irqsave() in the other
> contexts. Update the relevant scoped_guard() invocations accordingly and
> remove the unnecessary comments.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> ---
>  drivers/firewire/core-transaction.c | 27 +++++----------------------
>  1 file changed, 5 insertions(+), 22 deletions(-)

I realized that the change is incorrect in the way to use these spin_lock
variants. Drop this from the series.


Regards

Takashi Sakamoto