Re: [PATCH] arm64: dts: rockchip: Add the front panel LEDs to Kobol Helios64

From: Igor Velkov

Date: Thu Oct 08 2026 - 20:53:15 EST


On Fri, Oct 09, 2026 at 00:44 UTC, sashiko-bot@xxxxxxxxxx wrote:
> The commit message lists a total of 7 LEDs being added (one network, one USB,
> and five SATA error LEDs). However, this code block adds an 8th LED for SATA
> activity on gpio4 RK_PD4.
>
> Was this SATA activity LED intended to be included in this patch, and if so,
> could the commit message be updated to mention it?

Yes, it was. The eighth one is LED5 on the board, "HDD Activity" in the
Kobol wiki [1]; the panel has no such LED. GPIO4_D4 only gates it: the
JMB585 activity outputs light it, and a low GPIO keeps it dark
(schematic, sheet 30). Hence default-state = "on".

[1] https://wiki.kobol.io/helios64/led/