RE: [RFC PATCH 08/15] x86/tdx: Add TDG.MMIO.ACCEPT module call wrapper for TDX Connect

From: Duan, Zhenzhong

Date: Thu Oct 08 2026 - 22:18:38 EST




>-----Original Message-----
>From: Edgecombe, Rick P <rick.p.edgecombe@xxxxxxxxx>
>Subject: Re: [RFC PATCH 08/15] x86/tdx: Add TDG.MMIO.ACCEPT module call
>wrapper for TDX Connect
>
>On Thu, 2026-10-08 at 05:49 +0000, Duan, Zhenzhong wrote:
>> > int tdx_mcall_mmio_accept(struct pci_dev *dev, struct pci_tsm_mmio_entry
>> > *entry)
>> >
>> > What do you think?
>>
>> Yes, it's cleaner. But how about below to use func_id as first parameter to
>> align with other TDI specific mcalls.
>>
>> int tdx_mcall_mmio_accept(u64 func_id, struct pci_tsm_mmio_entry *entry)
>>
>> Or maybe passing "struct pci_dev *dev" for all TDI specific mcalls?
>
>I haven't processed all the calls yet. Can you consider passing it for all
>calls? If that works, it seems reasonable. Similar to what we do for the host
>calls.

Will do.

Thanks
Zhenzhong