RE: [PATCH v5 03/27] cxl: Move component register defines to uapi/cxl/cxl_regs.h

[Manish Honap]

> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Tuesday, September 22, 2026 7:14 AM
> To: Manish Honap <mhonap@xxxxxxxxxx>
> Cc: alex@xxxxxxxxxxx; jgg@xxxxxxxx; Ankit Agrawal <ankita@xxxxxxxxxx>;
> dave.jiang@xxxxxxxxx; alejandro.lucero-palau@xxxxxxx; Srirangan
> Madhavan <smadhavan@xxxxxxxxxx>; corbet@xxxxxxx;
> skhan@xxxxxxxxxxxxxxxxxxx; dave@xxxxxxxxxxxx; alison.schofield@xxxxxxxxx;
> vishal.l.verma@xxxxxxxxx; iweiny@xxxxxxxxxx; ming.li@xxxxxxxxxxxx; Yishai
> Hadas <yishaih@xxxxxxxxxx>; Shameer Kolothum Thodi
> <skolothumtho@xxxxxxxxxx>; kevin.tian@xxxxxxxxx; bhelgaas@xxxxxxxxxx;
> dmatlack@xxxxxxxxxx; kees@xxxxxxxxxx; gustavoars@xxxxxxxxxx; Neo Jia
> <cjia@xxxxxxxxxx>; Krishnakant Jaju <kjaju@xxxxxxxxxx>; Vikram Sethi
> <vsethi@xxxxxxxxxx>; Zhi Wang <zhiw@xxxxxxxxxx>; linux-
> doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx;
> linux-cxl@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-
> kselftest@xxxxxxxxxxxxxxx; linux-hardening@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 03/27] cxl: Move component register defines to
> uapi/cxl/cxl_regs.h
> 
> External email: Use caution opening links or attachments
> 
> 
> On Thu, 17 Sep 2026 00:05:16 +0530
> <mhonap@xxxxxxxxxx> wrote:
> 
> > From: Manish Honap <mhonap@xxxxxxxxxx>
> >
> > The CXL component and HDM decoder register layout is spec-defined and
> > is needed by a userspace consumer that cannot include the private
> > drivers/cxl/cxl.h
> >
> > The vfio-cxl selftest
> > (tools/testing/selftests/vfio/vfio_cxl_type2_test.c) builds against
> > installed uapi headers only. Move those defines to a new uapi header,
> > the way PCI register offsets live in uapi pci_regs.h, and include it
> > from drivers/cxl/cxl.h so existing in-kernel users are unchanged.
> >
> > No functional change; the GENMASK and BIT forms are written as plain
> > values as a uapi header requirement.
> 
> I thought we'd fixed that these days...  And indeed we have see
> include/uapi/linux/bits.h for __GENMASK() and include/uapi/linux/const.h for
> _BITUL()
> 
> Both are in use in pci_regs.h for instance.

Thank you. I think I missed these. I will update the file and the commit message accordingly.

> 
> Jonathan