Re: Re: [PATCH v4 3/7] riscv: dts: eswin: eic7700: add pinctrl support

[Yulin Lu]

Hi Samuel,

...
> 
> > +	default-pins-grp {
> 
> My assumption is that there would be one group per peripheral (e.g. SPI bus,
> eMMC, UART) that groups all of the pins used by that peripheral, with multiple
> "-pins" nodes in the case that subsets of those pins need different pinconf
> settings.
> 

I think users can define groups based on their usage requirements (a group can
contain definitions for gpio, uart, i2c, and other pins), and referencing a group
will apply the configuration for all the pins in it. Alternatively, users can
reference individual pins directly to configure just one item. Which design to
choose is determined by the user's actual use case, so I have listed out the
definitions for all the pins here.

...
> > diff --git a/arch/riscv/boot/dts/eswin/eic7700.dtsi b/arch/riscv/boot/dts/eswin/eic7700.dtsi
> > index b3a230870315..b16e3e28632c 100644
> > --- a/arch/riscv/boot/dts/eswin/eic7700.dtsi
> > +++ b/arch/riscv/boot/dts/eswin/eic7700.dtsi
> > @@ -349,6 +349,11 @@ gpioD: gpio-port@3 {
> >  			};
> >  		};
> >  
> > +		pinctrl: pinctrl@51600080 {
> > +			compatible = "eswin,eic7700-pinctrl";
> > +			reg = <0x0 0x51600080 0x0 0x1fff80>;
> > +		};
> > +
> >  		clk: clock-controller@51828000 {
> >  			compatible = "eswin,eic7700-clock";
> >  			reg = <0x0 0x51828000 0x0 0x300>;

We will change the other comments in next version.

Regards,
Yulin Lu