Re: [PATCH] xen/pcifront: Fix PCI device reference leak in pcifront_common_process()

[Juergen Gross]

On 17.09.26 15:29, Wentao Liang wrote:
> pcifront_common_process() gets a reference to the PCI device with
> pci_get_domain_bus_and_slot() and only drops it on the early error
> path.  Returning directly from the AER handler switch instead of
> recording the result and falling through to the common
> pci_dev_put(pcidev) leaks the reference on every successful call.
>
> Collect the handler result in a variable and drop the reference on the
> single exit path again.
>
> Fixes: 34ab316d7287 ("xen/pcifront: Drop pcifront_common_process() tests of pcidev, pdrv")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature