Re: [PATCH v5 4/6] media: qcom: camss: vfe: Remove unused frame-skip
From: bod
Date: Fri Oct 09 2026 - 05:18:25 EST
On 2026-09-28 17:45 +0530, Hitesh Patel wrote:
> From: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
>
> The frame_skip logic originates from older VFE implementations where it
> was used to program the hardware frame-drop mechanism during stream
> startup. The Gen2 path neither consumes the returned value nor programs
> any corresponding frame-drop configuration, making the sensor lookup and
> g_skip_frames() useless.
>
> Remove the unused code and associated local variables.
>
> Furthermore, startup frame filtering is generally better handled in
> userspace camera stacks, which can discard unstable frames as needed
> without relying on driver-specific mechanisms.
>
> Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> Signed-off-by: Hitesh Patel <hitesh@xxxxxxxxxxxxxx>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---
bod