Re: [PATCH 1/2] dt-bindings: media: i2c: Add OmniVision OV3660 image sensor

[Krzysztof Kozlowski]

On Thu, Oct 08, 2026 at 11:06:49PM +0700, Nguyen Minh Tien wrote:
> Add a binding for the OmniVision OV3660, a 1/5" 3 megapixel CMOS image
> sensor with an image signal processor and a parallel (DVP) output.
> 
> Its 1.5 V core can come from an internal regulator, so the DVDD supply
> is optional. The endpoint gives the bus width, the sync and pixel clock
> polarities, and the pixel clock frequencies the board can take.
> 
> Assisted-by: Claude:claude-opus-5-5

: LLM

(see current docs)

> Signed-off-by: Nguyen Minh Tien <tien.nguyenminh@xxxxxxxxxxxxxxxxxx>

...

> +  avdd-supply:
> +    description: Analog voltage supply, 2.8 volts
> +
> +  dovdd-supply:
> +    description: Digital I/O voltage supply, 1.8 or 2.8 volts
> +
> +  dvdd-supply:
> +    description:
> +      Digital core voltage supply, 1.5 volts. Not needed when the internal
> +      regulator is used.
> +
> +  powerdown-gpios:
> +    maxItems: 1
> +    description: Reference to the GPIO connected to the PWDN pin, if any.
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Reference to the GPIO connected to the RESETB pin, if any.
> +

All this looks the same as ovti,ov2732, so are you sure bindings should
be different?

> +  port:
> +    description: Parallel output port
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          bus-width:
> +            enum: [8, 10]
> +
> +          data-shift:
> +            enum: [0, 2]
> +
> +          pclk-sample:
> +            enum: [0, 1]

I guess these constraints are different than other ov-sensors...

> +
> +        required:
> +          - bus-width
> +          - hsync-active
> +          - vsync-active
> +          - pclk-sample
> +          - link-frequencies

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof