RE: [PATCH net 04/10] net: ethernet: adi: Move setting of netops to fix crash

[Regus, Ciprian]

> adin1140_probe() calls adin1140_phy_init(), which connects the PHY,
> before netdev->netdev_ops is assigned. phy_attach_direct() ->
> phy_link_topo_add_phy() reads dev->netdev_ops through
> netdev_need_ops_lock() since the commit in question, so probing crashes
> with a NULL pointer dereference when CONFIG_NET_SHAPER is enabled.
> 
> Assign netdev_ops before the PHY attach, as was done for emac in commit
> 7c9f391ec89c ("net: emac: move setting of netops to fix crash").
> 
> Fixes: ded86da4bbb7 ("net: ethtool: relax ethnl_req_get_phydev() locking
> assertion")
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>

Reviewed-by: Ciprian Regus <ciprian.regus@xxxxxxxxxx>