Re: [PATCH 2/2] sparc32: remove redundant memset in srmmu_nocache_init()

[Andreas Larsson]

On 2026-08-27 16:54, Sang-Heon Jeon wrote:
> memblock_alloc_or_panic() returns zeroed memory, so the memset after
> the allocation is redundant.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>
> ---
>  arch/sparc/mm/srmmu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
> index 9a74902ad181..f9a92a07a255 100644
> --- a/arch/sparc/mm/srmmu.c
> +++ b/arch/sparc/mm/srmmu.c
> @@ -279,7 +279,6 @@ static void __init srmmu_nocache_init(void)
>  
>  	srmmu_nocache_pool = memblock_alloc_or_panic(srmmu_nocache_size,
>  					    SRMMU_NOCACHE_ALIGN_MAX);
> -	memset(srmmu_nocache_pool, 0, srmmu_nocache_size);
>  
>  	srmmu_nocache_bitmap =
>  		memblock_alloc_or_panic(BITS_TO_LONGS(bitmap_bits) * sizeof(long),

Reviewed-by: Andreas Larsson <andreas@xxxxxxxxxxx>

Picking this up to my for-next.

Thanks,
Andreas