Re: [PATCH 2/2] ASoC: codecs: rt5659: propagate GPIO errors

From: Alvin Šipraga

Date: Fri Oct 09 2026 - 11:49:10 EST


On Fri, Oct 09, 2026 at 06:22:04PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> devm_gpiod_get_optional() may return an error pointer, including
> -EPROBE_DEFER, but rt5659_i2c_probe() does not handle these errors
> for the ldo1-en GPIO and does not check for errors for the reset GPIO.
>
> Check the return values and propagate GPIO lookup errors.
>
> Fixes: d3cb2de2479b ("ASoC: rt5659: add rt5659 codec driver")
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>

Reviewed-by: Alvin Šipraga <alvin.sipraga@xxxxxxxxxx>

> ---
> sound/soc/codecs/rt5659.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)