Re: [PATCH 4/4] riscv: dts: spacemit: k3-com260-ifx: Add rfkill nodes

[Shengyu Qu]

Hi,

I don't think doing like this is correct.. We have a dedicated M.2 Ekey
binding and should use that:

https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/connector/pcie-m2-e-connector.yaml

Best regards,
Shengyu

在 2026/9/29 07:18, Jennifer Berringer 写道:
> K3 CoM260 IFX has an M.2 E-key slot for wireless. Add rfkill nodes for
> the GPIOs that control the slot's W_DISABLE1# and W_DISABLE2# pins for
> WLAN and Bluetooth.
>
> Signed-off-by: Jennifer Berringer <jberring@xxxxxxxxxx>
> ---
>   arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> index 01e286cb05797..cd878340e5add 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> @@ -47,6 +47,20 @@ reg_aux_vcc3v3: regulator-aux-vcc3v3 {
>   		regulator-max-microvolt = <3300000>;
>   		regulator-always-on;
>   	};
> +
> +	rfkill-pcie-wlan {
> +		compatible = "rfkill-gpio";
> +		label = "rfkill-pcie-wlan";
> +		radio-type = "wlan";
> +		shutdown-gpios = <&gpio K3_GPIO(73) GPIO_ACTIVE_LOW>;
> +	};
> +
> +	rfkill-usb-bt {
> +		compatible = "rfkill-gpio";
> +		label = "rfkill-usb-bt";
> +		radio-type = "bluetooth";
> +		shutdown-gpios = <&gpio K3_GPIO(57) GPIO_ACTIVE_LOW>;
> +	};
>   };
>   
>   &combophy {