Re: [PATCH] lib/base64: Silence clang-24 -Wconstant-conversion with diag pragmas

[Nathan Chancellor]

On Sat, Oct 10, 2026 at 12:59:01AM +0800, Kuan-Wei Chiu wrote:
> Reading the issue comment in the link, it seems somewhat subjective and
> controversial whether the compiler should emit a warning in this
> scenario. I'm not a compiler expert, but from a user's perspective,
> it's a bit disappointing when we have to deal with this. When we are
> confident that the code is correct and have provided the compiler with
> enough context to determine that there is no runtime issue, suddenly
> getting a new warning after an upgrade is a bit frustrating. But
> anyway, let's go with this workaround to keep the compiler happy.

Yes, I 100% agree. I have tried to make that a little clearer to the
clang folks, I guess we will see where that goes. Thanks for being
pragmatic here. We can always revisit this depending on how the upstream
discussions go but I would rather get this rolling on our side now, as
our CI has been broken for over three weeks and has missed other
regressions in the meantime.

-- 
Cheers,
Nathan