Re: [PATCH v2 0/5] firewire: core: make execution context assumptions explicit

[Takashi Sakamoto]

Hi,

On Fri, Oct 09, 2026 at 09:10:43PM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> This series is take 2 of the previous series[1].
> 
> Recent code changes have guaranteed the execution contexts of several
> functions in the transaction layer. Based on this, this series adds
> might_sleep() calls where appropriate. It also adds sparse annotations
> and lockdep checks for several locks to document the expected locking
> context and help detect incorrect locking behavior.
> 
> Chanes from v1:
> * drop a patch to arrange spinlock usages for reconsideration
> 
> [1] https://lore.kernel.org/lkml/20261008234432.251412-1-o-takashi@xxxxxxxxxxxxx/
> 
> 
> Takashi Sakamoto (5):
>   firewire: core: add might_sleep() checks
>   firewire: core: use sparse annotations and lockdep checks for
>     transaction lock
>   firewire: core: use sparse annotations and lockdep checks for topology
>     map lock
>   firewire: core: use sparse annotations and lockdep checks for split
>     timeout lock
>   firewire: core: narrow the card lock scope when accessing node_id
> 
>  drivers/firewire/core-topology.c    |  3 ++
>  drivers/firewire/core-transaction.c | 70 ++++++++++++++++++++++++++---
>  2 files changed, 66 insertions(+), 7 deletions(-)

I realized that Sparse nowadays seems to be excluded from in-kernel
context analysis[1]. Clang took over this function with more sophisticated
features.

Let me work for refining this series with Compiler-based Context
Analysis[2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b63d0ae94cc
[2] https://docs.kernel.org/dev-tools/context-analysis.html


Regards

Takashi Sakamoto