Re: [PATCH v3 5/7] ASoC: codec: pcm1681: Enable the PCM1681 supplies
From: Wang, Sen
Date: Fri Oct 09 2026 - 23:14:34 EST
On 10/9/2026 8:12 AM, Mohammad Rafi Shaik wrote:
From: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>Reviewed-by: Sen Wang <sen@xxxxxx>
The driver assumes that the analog and digital supplies of the DAC are
already up by the time it probes. That only holds when the rails are
hardwired or left on by the bootloader. Boards which gate them, like
the Qualcomm Nord RRD and Ride, have no way to get them enabled, and
the first register access then fails.
Enable the VCC1, VCC2 and VDD supplies before touching the clock or the
regmap, so that the DAC is powered whenever the driver is bound. The
supplies are optional as far as the regulator core is concerned, so
boards which do not describe them keep working through the dummy
regulator.
Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
---