Re: [PATCH v2 0/7] HID: asus: ASUS Zenbook Duo keyboard support

[Rebecca Mara Müller]

On Fri, Oct 09, 2026 at 05:34:27PM +0200, Paolo Pisati wrote:
> Rebecca Mara Müller posted an independent patch for the UX8407AA
> keyboard in August [1]. This series follows it in using
> HID_CONNECT_HIDINPUT_FORCE and in binding the USB IDs by group, and
> carries her re-sent handshake as the last patch.

Thank you for picking up the handshake re-send, and for the kind words.

I tested the whole series on a UX8407AA: v2 applied on top of
base-commit 8099f9da59f1, hid-asus.c built unmodified as an out-of-tree
module against a 7.0.11-based distribution kernel (Pop!_OS), with my
userspace workaround (which sends the handshake through hidraw) stopped.

- Docked (USB, 0b05:1cd7), three dock cycles: the five keyboard
  interfaces bind to hid-asus and the touchpad stays with
  hid-multitouch. Hotkeys, keyboard backlight (levels 0-3),
  volume/mute, mic mute, the screenshot key and Fn+F profile cycling
  (balanced <-> performance) all work. The delayed handshake re-send
  succeeded every time.
- Module loaded with the keyboard already docked, as at boot: same
  result.
- Undocked over Bluetooth (0b05:1cd8): the same keys work, and the
  touchpad stays with hid-multitouch.

One observation, in case it helps someone else: while my userspace
tool was still running, the re-send failed once with
"Asus handshake 5a failed to send: -32", presumably because the tool
had just sent its own handshake. With the tool stopped it never failed.

Tested-by: Rebecca Mara Müller <rebecca.mara@xxxxxxxxx> # UX8407AA

On patch 7: my original patch, and the mail it was sent with, were
written with the help of an AI assistant (Claude, Fable 5.0), which I
should have stated in a trailer at the time. The "Assisted-by: LLM"
in 7/7 follows your note, so it only covers your adaptation. If you
respin the series, please feel free to add

Assisted-by: LLM

above my Signed-off-by as well.

Thanks,
Rebecca