Re: [PATCH 10/13] ASoC: intel: atom: Discard pm_runtime_put_autosuspend() return value

[Cezary Rojewski]

On 10/7/2026 1:13 AM, Brian Norris wrote:
> Propagating the pm_runtime_put_autosuspend() return value to callers is
> not particularly useful.
> 
> Returning an error code from pm_runtime_put_autosuspend() merely means
> that it has not queued up a timer or work item to check whether or not
> the device can be suspended and there are many perfectly valid
> situations in which that can happen, like after writing "on" to the
> device's runtime PM "control" attribute in sysfs for one example.
> 
> Modify sst_pm_runtime_put() to discard the pm_runtime_put_autosuspend()
> return value, change its return type to void, and update its callers in
> sst_power_control() accordingly.
> 
> Note that in one error path for sst_power_control(), we would previously
> overwrite one error code (from "FW download fail") with the return code
> from pm_runtime_put_autosuspend(). This was probably an unexpected
> behavior, which is now changed to propagate the sst_load_fw() error
> code.
> 
> This will facilitate a planned change of the
> pm_runtime_put_autosuspend() return type to void in the future, similar
> to commit 3afd8df02433 ("PM: runtime: Change pm_runtime_put() return
> type to void").
> 
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> This patch is independent of the rest of the series, except for the end
> (changing the return type). I expect it can be applied by individual
> maintainers, and we pick up the end once the dust is settled.
Acked-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>