RE: [PATCH v2] wifi: rtw88: 8723b: avoid converting RX SNR twice
From: Ping-Ke Shih
Date: Mon Oct 12 2026 - 01:55:15 EST
Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> >
> > rtw8723b_query_phy_status_ofdm() divides the SNR report by two when
> > filling pkt_stat->rx_snr, then shifts it again when updating
> > dm_info->rx_snr. This halves the SNR used for diagnostics and average
> > statistics.
> >
> > Store the raw report in pkt_stat->rx_snr and convert it only when
> > updating dm_info->rx_snr, as the other chip drivers do.
> >
> > Fixes: d726c70ce082 ("wifi: rtw88: 8723b: add the RTL8723B chip driver")
> > Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> Ping-Ke should fixes tag be present here if this commit isn't in
> mainline yet?
My pull-request including the patch was merged, so the SHA1 will be constant.
Ping-Ke